Added Github\HttpClient\HttpClient::$client #393
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| /** | ||
| * @var ClientInterface | ||
| */ | ||
| public $client; |
There was a problem hiding this comment.
should be private variable
There was a problem hiding this comment.
No. Check please code
There was a problem hiding this comment.
what code should I check? can you please elaborate?
There was a problem hiding this comment.
@cursedcoder For example lib/Github/Client.php:249 (current master branch):
$this->getHttpClient()->client->setBaseUrl($baseUrl . '/api/v3');
There was a problem hiding this comment.
Making it private would be breaking anyway since it was defaulting to public already?
There was a problem hiding this comment.
It seems to me - yes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Github\HttpClient\HttpClient::$clientdeclared dynamically